fix(sew): limit go routine spawn for activating delegation #84
Conversation
| @@ -539,6 +539,10 @@ func (sew *StakingEventWatcher) checkBtcForStakingTx() error { | |||
| } | |||
|
|
|||
| for _, del := range delegations { | |||
| if del.ActivationInProgress { | |||
There was a problem hiding this comment.
Would be better if we didn't get all the tracked delegations at once, because it could happen that we load the delegations to iterate, after that someone updates the del.ActivationInProgress value and this iterator would not know about it
If we are okay with this scenario the code looks good to me
There was a problem hiding this comment.
I do agree with what you say. Tho I do think there's not a high chance for this to happen. What approach would you recommend, first thing that come to my mind was using Iterators
There was a problem hiding this comment.
yes, like an iterator would work or a function which gets the next del that is not activated
There was a problem hiding this comment.
will create an issue to improve this, not a high priority, worst case is we retry
Limit go routines getting spawned and doing extra work.